fix BB-758 : Link from edit page to entity page #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonkeyDo
requested changes
Jan 12, 2024
Comment on lines
95
to
97
| <div> | ||
| <a href={entityURL}>{heading}</a> | ||
| </div> |
There was a problem hiding this comment.
Following my comment above, in the case that entity is falsy we know it's not an edit but a creation, in which case we can use the heading directly instead of creating a broken link.
{entityURL ? <a href={entityURL}>{heading}</a> : heading}
There was a problem hiding this comment.
yup I think this is much better
|
Thank you for reviewing my PR , I have made the suggested changes please have a look |
MonkeyDo
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
BB-758Solution
Using anchor tag I added a link inside the heading of entity in editor page , see the screenshot . A direct link to entity page from entity editor page makes it very convenient while comparing the fields being edited with the original ones
2024-01-03.22-24-53.mp4
Areas of Impact
This PR effect the entity-editor page section of the codebase