Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix "Checking translation domain in statistics code" test
1. The `!` negation does not actually cause the script to exit (despite `set -e`) if the `git grep` succeeds (finds matches). See [1]: "The shell does not exit if the command that fails is part of the command list immediately following a while or until keyword, part of the test in an if statement, part of any command executed in a && or || list except the command following the final && or ||, any command in a pipeline but the last, or if the command’s return status is being inverted with !." Thus I've replaced the `!` at the beginning of the command with `&& { exit 1; }` at the end. 2. It appears that the tests could hang on the `git grep` command if it produced too many matches due to the results being paged. I've also added the `--no-pager` flag to resolve this. [1] https://www.gnu.org/software/bash/manual/html_node/The-Set-Builtin.html:
- Loading branch information