Use Type::Tiny based types in most cases #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haarg
force-pushed
the
haarg/type-tiny
branch
2 times, most recently
from
67fa81d to
8d60a57
Compare
mickeyn
previously approved these changes
Jan 29, 2025
haarg
force-pushed
the
haarg/type-tiny
branch
from
8d60a57 to
8a9846e
Compare
mickeyn
previously approved these changes
Jan 29, 2025
haarg
force-pushed
the
haarg/type-tiny
branch
5 times, most recently
from
a3ae2ab to
6e4e1d7
Compare
Log::Contextual requires a logger to be configured. The scripts confgure one, but anything outside the scripts may not have one configured. Log::Contextual::Easy::Default provides a default logger that warns if a real logger isn't configured. This can allow the module to be used outside the scripts without errors.
MooseX::Getopt is used in our scripts, and we need to tell it about some of the types we use. But that is only needed in the scripts. Rather than setting it up in the type module, we can set it up in the role that is used in every script. This means it won't be loaded in the web app.
haarg
force-pushed
the
haarg/type-tiny
branch
from
6e4e1d7 to
02c1d5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types in the document classes are not changed, as they should be going away soon.