Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option "url_safe" to "to_base64" function #386

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Conversation

dr0i
Copy link
Member

@dr0i dr0i commented Nov 14, 2024

Resolves #384.

@dr0i
Copy link
Member Author

dr0i commented Nov 14, 2024

Other than suggested in #384 we cannot use an option with hyphen, like the suggested url-safe. Options can use the underscore _, though.
Not sure if we want to use camel case (urlSafe? safeUrl?) or safe_url instead of url_safe ?

@TobiasNx
Copy link
Collaborator

Other than suggested in #384 we cannot use an option with hyphen, like the suggested url-safe. Options can use the underscore _, though. Not sure if we want to use camel case (urlSafe? safeUrl?) or safe_url instead of url_safe ?

url_safe as stated here: https://www.base64encode.org/

README.md Outdated Show resolved Hide resolved
@blackwinter blackwinter assigned dr0i and unassigned blackwinter Nov 14, 2024
@dr0i dr0i assigned blackwinter and unassigned dr0i Nov 14, 2024
@blackwinter blackwinter assigned dr0i and unassigned blackwinter Nov 14, 2024
@dr0i dr0i assigned blackwinter and unassigned dr0i Nov 15, 2024
@blackwinter blackwinter assigned dr0i and unassigned blackwinter Nov 15, 2024
@dr0i dr0i merged commit 93afd59 into master Nov 15, 2024
1 check passed
@dr0i dr0i deleted the 384-encodeUrlToBase64 branch November 15, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add option to encode a string url-safe with to_base64
3 participants