Add log4j logging and bridge #387
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,18 @@ | ||||||||||
| <?xml version="1.0" encoding="UTF-8"?> | ||||||||||
| <!DOCTYPE log4j:configuration SYSTEM "http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/xml/doc-files/log4j.dtd"> | ||||||||||
|
|
||||||||||
| <log4j:configuration> | ||||||||||
| <appender name="stdout" class="org.apache.log4j.ConsoleAppender"> | ||||||||||
| <layout class="org.apache.log4j.PatternLayout"> | ||||||||||
| <param name="ConversionPattern" | ||||||||||
| value="%-5p [%t] [%c{1}] %m%n" /> | ||||||||||
| </layout> | ||||||||||
| </appender> | ||||||||||
|
|
||||||||||
| <root> | ||||||||||
| <priority value="INFO" /> | ||||||||||
|
There was a problem hiding this comment. Simplify changing the log level at runtime:
Suggested change
There was a problem hiding this comment. How is the variable set? There was a problem hiding this comment. hmpf, no this works , BUT it's always on DEBUG level regardless what I set .... oh , logging is so complicated ... There was a problem hiding this comment. Oh, sorry, I overlooked that we're on Log4j 1.x which doesn't seem to support property substitution. There was a problem hiding this comment. No, it doesn't work. It's effectively an invalid/empty log level. There was a problem hiding this comment. Okay, apparently it does support property substitution, it's just not readily documented. However, I wasn't able to figure out how to supply a default value in the configuration file. So it gets a little more complicated: <priority value="${org.metafacture.metafix.logLevel}" />diff --git metafix-runner/build.gradle metafix-runner/build.gradle
index 1179b5c..ab71abb 100644
--- metafix-runner/build.gradle
+++ metafix-runner/build.gradle
@@ -39,11 +39,15 @@ dependencies {
application {
mainClass = 'org.metafacture.runner.Flux'
+ applicationDefaultJvmArgs = [
+ "-Dorg.metafacture.metafix.logLevel=INFO"
+ ]
+
if (project.hasProperty('profile')) {
def file = project.getProperty('profile') ?: project.name
def depth = project.hasProperty('profile.depth') ? project.getProperty('profile.depth') : 8
- applicationDefaultJvmArgs = [
+ applicationDefaultJvmArgs += [
"-XX:FlightRecorderOptions=stackdepth=${depth}",
"-XX:StartFlightRecording=dumponexit=true,filename=${file}.jfr,settings=profile"
]Then run with There was a problem hiding this comment. Allow changing the log level at runtime:
Suggested change
Specify default log level: diff --git metafix-runner/build.gradle metafix-runner/build.gradle
index 1179b5c..ab71abb 100644
--- metafix-runner/build.gradle
+++ metafix-runner/build.gradle
@@ -39,11 +39,15 @@ dependencies {
application {
mainClass = 'org.metafacture.runner.Flux'
+ applicationDefaultJvmArgs = [
+ "-Dorg.metafacture.metafix.logLevel=INFO"
+ ]
+
if (project.hasProperty('profile')) {
def file = project.getProperty('profile') ?: project.name
def depth = project.hasProperty('profile.depth') ? project.getProperty('profile.depth') : 8
- applicationDefaultJvmArgs = [
+ applicationDefaultJvmArgs += [
"-XX:FlightRecorderOptions=stackdepth=${depth}",
"-XX:StartFlightRecording=dumponexit=true,filename=${file}.jfr,settings=profile"
]Change log level at runtime with |
||||||||||
| <appender-ref ref="stdout" /> | ||||||||||
| </root> | ||||||||||
|
|
||||||||||
| </log4j:configuration> | ||||||||||
|
|
||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this suggestion, I get no logging output, and the same
Class path contains multiple SLF4J bindings.warning that I get without this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That warning aside (different issue, IMO), you would have to increase the log level to
DEBUG.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with
DEBUGinlog4j.xml: no logging output. As you wrote below, it must be using some other config?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not what I saw. Changing the log level (priority) in
log4j.xmland then running./gradlew installDistyields debug output withlog-object.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, I have
<priority value="DEBUG" />inmetafix/src/main/resources/log4j.xml, onlyruntimeOnly "org.slf4j:slf4j-log4j12:${versions.slf4j}"added inmetafix-runner/build.gradle: no logging output forlog-object.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And you ran
./gradlew installDistafterwards? For me onmaster:log4j.xmlfrom metafacture-core tometafix/src/main/resources/.infotoDEBUGinmetafix/src/main/resources/log4j.xml.runtimeOnly "org.slf4j:slf4j-log4j12:${versions.slf4j}"tometafix-runner/build.gradle../gradlew installDist.metafix-runner/build/install/metafix-runnerdirectory.bin/metafix-runner /path/to/flux-with-log-object.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blackwinter your proposal is working for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried it on my home machine, and here it works. Maybe some cached dependency bringing in some other config file on my office machine? So that would be +1 for using only
runtimeOnly "org.slf4j:slf4j-log4j12:${versions.slf4j}". However, it works here even without adding any dependency, just by switchingINFOtoDEBUGinmetafix/src/main/resources/log4j.xml.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Probably because it's pulled in by metafacture-runner. So let's just drop it altogether then.