Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flux commands examples #148

Merged
merged 18 commits into from
Nov 23, 2023
Merged

Add flux commands examples #148

merged 18 commits into from
Nov 23, 2023

Conversation

TobiasNx
Copy link
Contributor

Add examples for Flux Commands

@maipet Examples for Fix Functions should be added in a similar way also missing examples for Flux Commands but no logging functions (since #141 us not solved yet)

@TobiasNx
Copy link
Contributor Author

@katauber can you identify which workflows fail?

@TobiasNx TobiasNx requested a review from katauber November 16, 2023 10:47
@katauber
Copy link
Member

If you run lein test locally, you can see which workflows fail (I think in the Github Actions, the order of logs is a little bit mixed up).
E.g.:
image

Here you can see, that às_formeta_records` throws the following error.

I'll add the PR to the Metafacture Project and set a status so I have a better overview, what my tasks are.

@katauber
Copy link
Member

For this first example there is something wrong with the link format:
image

There's a second example where only should be a PG link.

@TobiasNx
Copy link
Contributor Author

I added a couple of fix functions too. One test files because of #145

@TobiasNx TobiasNx force-pushed the addFluxCommandsExamples branch from a89526b to 80a5164 Compare November 23, 2023 10:01
@TobiasNx TobiasNx assigned katauber and unassigned TobiasNx Nov 23, 2023
@katauber katauber merged commit f4d9766 into main Nov 23, 2023
@katauber katauber deleted the addFluxCommandsExamples branch November 23, 2023 11:57
@katauber
Copy link
Member

Deployed to https://test.metafacture.org/playground/

@katauber
Copy link
Member

Deployed to https://metafacture.org/playground/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants