Add SUM and IPMI tools. #28
Conversation
- Replace alpine with debian, since the sum tool is a dynamic linked library, and even alpines gcompat doesn't contain mallopt, which SUM needs. - Build ipmitool from scratch to get cherry picked bug fixes.
Makefile
Outdated
| @@ -45,7 +45,8 @@ build-linux: | |||
| ifeq ($(GO_VERSION), 0) | |||
| $(error build requies go version 1.22 or higher) | |||
| endif | |||
| CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -o bioscfg \ | |||
| # no CGO_ENABLED=0, because we are using a debian image to support the `sum` tool. | |||
There was a problem hiding this comment.
I think you still want to disable linking against libc though.
There was a problem hiding this comment.
We don’t need it in bioscfg, b/c we ran on alpine and didn’t link against their libc. We don’t need to change this here.
There was a problem hiding this comment.
Could be issues with inconsistencies between statically linked in our other services, and the dynamic linked libs here. So not worth the risk with how little memory you save on the binary size. So going to revert this.
| # IPMI Tool | ||
| # | ||
| # cherry-pick'ed 1edb0e27e44196d1ebe449aba0b9be22d376bcb6 | ||
| # to fix https://github.com/ipmitool/ipmitool/issues/377 | ||
| # | ||
| ARG IPMITOOL_REPO=https://github.com/ipmitool/ipmitool.git | ||
| ARG IPMITOOL_COMMIT=19d78782d795d0cf4ceefe655f616210c9143e62 | ||
| ARG IPMITOOL_CHERRY_PICK=1edb0e27e44196d1ebe449aba0b9be22d376bcb6 | ||
| ARG IPMITOOL_BUILD_DEPENDENCIES="git curl make autoconf automake libtool libreadline-dev" |
There was a problem hiding this comment.
For solr, we just install ipmitool with apt-get, and then copy enterprise-numbers.txt from the solr repo to the expected directory. That way, we aren't dependent on the IANA servers at runtime.
There was a problem hiding this comment.
My understanding we are doing this for a bugfix in ipmitool. Thats why the cherry pick is there. We dont want to up the version, or change the version because we cant trust ipmitool to not change its functionality.
There was a problem hiding this comment.
the thing about the IANA servers makes sense though. Maybe we can talk about it.
There was a problem hiding this comment.
Also, if we should do this. Then we much also do this for flipflop. It has the same issue. This should be a separate ticket.
jakeschuurmans
force-pushed
the
FS-1833
branch
from
cfd923b to
d07bbb8
Compare
Note: This increases the size of the docker image from 89MB to 220MB.