First Steps for bioscfg work #5
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Remove all hollow references. Need to move from rivets controller to ctrl to do so. This is a "stepping stone" for later work.
jakeschuurmans
force-pushed
the
FS-1744_1
branch
from
fdb031f
to
562013d
Compare
| return &TaskRunner{ | ||
| publisher: publisher, | ||
| task: task, | ||
| taskStatus: NewTaskStatus(task.Name(), rctypes.Pending), | ||
| oldTask: oldTask, |
There was a problem hiding this comment.
What is old an old task?
There was a problem hiding this comment.
old task struct. Im trying to limit changes in this PR to prevent having to change everything from top to bottom at once. Moving over to Ctrl requires you to use the new Task Struct, and not the one in internal/tasks.go. So this PR will result in both being used at once. Once its merged Ill throw up the next PR that will remove the oldTask and its code.
Update github runners
Remove all hollow references.
Need to move from rivets controller to ctrl to do so. This is a "stepping stone" for later work.
I did my best to split this up, but you run into a domino effect of stuff. More PRs on the horizon to clean this up I promise.