Get BiosCfg ready for prod #6
Conversation
Update config, making it uniform with other controllers Remove "store" interface Add BMC interface for later use Update rivets
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jakeschuurmans
force-pushed
the
FS-1744_2
branch
from
db83bfc
to
6164f9d
Compare
Refactor CMD Replace old tasks and steps with new Task Replace slog with logrus. I know we want to move off logrus, but I think we need to do this at a later date. Move handler to bioscfg move publisher to bioscfg, in its own file
jakeschuurmans
force-pushed
the
FS-1744_2
branch
from
6164f9d
to
324f17a
Compare
Dockerfile
Outdated
| FROM alpine:3.8 as runner | ||
| FROM alpine:latest | ||
|
|
||
| ENTRYPOINT ["/usr/sbin/bioscfg"] |
There was a problem hiding this comment.
Any reason why we moved the entrypoint up here? I don't know that it will affect the execution, but I've never really seen it NOT be the last line of Dockerfile.
There was a problem hiding this comment.
no, ill move it back. I forgot to change it back. I was dealing with a weird bug and trying some wild stuff to see what was up.
internal/store/fleetdb/client.go
Outdated
| // clientID defaults to 'flipflop' | ||
| clientID := "flipflop" |
There was a problem hiding this comment.
Why was this changed to flipflop, or was this copy pasta?
internal/bioscfg/bioscfg.go
Outdated
| bc := &BiosCfg{ | ||
| cfg: cfg, | ||
| logger: logger, | ||
| ctx: ctx, |
There was a problem hiding this comment.
Contexts are not meant to be stored in a struct:
Do not store Contexts inside a struct type; instead, pass a Context explicitly to each function that needs it.
There's probably nothing bad that will happen if we do add it to a struct, but best to use them as intended.
What does this PR do
Attempted to put the work in their own commits to help reading, and so I dont need as many PRs.