FS-1671; X13 Support #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakeschuurmans
force-pushed
the
FS-1671
branch
from
5bc35b2 to
1166a4d
Compare
jakeschuurmans
force-pushed
the
FS-1671
branch
from
1166a4d to
9ab35be
Compare
ofaurax
previously approved these changes
Nov 19, 2024
|
Please add a better title to the PR 🤣 |
DoctorVin
reviewed
Nov 19, 2024
providers/supermicro/supermicro.go
Outdated
| @@ -182,8 +182,7 @@ func (c *Client) Open(ctx context.Context) (err error) { | |||
| return err | |||
| } | |||
|
|
|||
| if !bytes.Contains(body, []byte(`url_redirect.cgi?url_name=mainmenu`)) && | |||
| !bytes.Contains(body, []byte(`url_redirect.cgi?url_name=topmenu`)) { | |||
| if !bytes.Contains(body, []byte(`url_redirect.cgi?url_name=topmenu`)) { | |||
| } | ||
| } | ||
|
|
||
| func stateFinalized(s redfish.TaskState) bool { |
There was a problem hiding this comment.
I low-key hate using a slice instead of a map here, but I don't hate it enough to demand a change.
| return "", err | ||
| } | ||
|
|
||
| // X13s dont create a new task id when going from upload to install, so we pass through the same one |
There was a problem hiding this comment.
Is this a redfish version thing? Or a model thing?
There was a problem hiding this comment.
Redfish.
X11 doesnt have a taskID at all, X12 creates a new taskID for each, and X13 keeps the same taskID
|
Is this work compatible with bmc-toolbox#394 ? |
This work will replace that work. |
ofaurax
pushed a commit
that referenced
this pull request
Feb 5, 2025
* X13 Inventory support * X13 Firmware update support * Fix up examples * remove duplicate import * fix x11 and x12 bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
Support for X13 inventory and X13 BIOS/BMC Firmware update
New example for firmware upload and firmware install uploaded