Add an API to compare inventory components #130
Conversation
Alva8756
force-pushed
the
component_compare_api
branch
from
0727b17 to
57fa03b
Compare
| // /inventory/compare | ||
| srvInventoryCompare := srvInventory.Group("/compare") | ||
| { | ||
| srvInventoryCompare.POST("/:uuid", amw.AuthRequired(readScopes("server")), r.compareInventory) | ||
| } |
There was a problem hiding this comment.
If I understand this correctly, a user has to POST some JSON of a server to /inventory/compare/{uuid} and fleetdb will compare that JSON with what is in the database, right? And we plan on using this to see if some data is out of sync with EMAPI?
I think the API would be easier to use if fleetdb did the work of getting the server JSON directly from EMAPI, instead of requiring the user to post the data. Then, you could just make this a GET request. It really shouldn't be a POST anyway. POST is meant for creating a resource, and nothing really gets created here. Would it be possible for fleetdb to get the inventory from EMAPI?
Also, it would be more RESTful to make the route /inventory/{uuid}/compare.
There was a problem hiding this comment.
Thanks John,
I realized Vince mentioned it's not good to let FleetDB depends on EMAPI as it will expand the dependency/binary size.
It looks it's more appropriate to move the function to the mctl as a tool. I will close this PR for that.
There was a problem hiding this comment.
Moved the PR to metal-toolbox/mctl#168
Users can use it to: