Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS-1266; Make pagination values public so i can access them from mctl #33

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

jakeschuurmans
Copy link
Contributor

No description provided.

DoctorVin
DoctorVin previously approved these changes Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 72.72%. Comparing base (7215512) to head (40d7259).

Files Patch % Lines
pkg/api/v1/pagination.go 25.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   72.72%   72.72%           
=======================================
  Files          38       38           
  Lines        3740     3740           
=======================================
  Hits         2720     2720           
  Misses        762      762           
  Partials      258      258           
Flag Coverage Δ
unittests 72.72% <25.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DoctorVin DoctorVin merged commit 18156cb into main Mar 21, 2024
2 of 3 checks passed
@DoctorVin DoctorVin deleted the FS-1266 branch March 21, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants