Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CREATE TABLE is generated from server service[1].
make test-database
can generate same tables oncrdb-v23.1.11
successfully[2].Tested with
add-server
fromsandbox
:Made some manual changes:
INSERT INTO server_credential_types(...)
to match existingINSERT
. Otherwise we will getsql: no rows in result set
when create credentials.-- Validate foreign key constraints
sections from [1]. It reports errors but it doesn't affect generated tables. We may want to add it back in the future.[1]
[2]