Firmware set fixes #228
Merged
Firmware set fixes #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lete as part of tests The cleanDB() method is invoked multiple times for each test, if a table cannot be deleted because of a constraint or some other cause, this method will now log the error as part of the test. This helps debug cause for failing tests quicker - in the case where the DB tables were not cleaned up by cleanDB().
… deletion When a firmware row is referenced by a firmware set, restrict deletion of the firmware row, This ensures referential integrity in firmware sets. Updates test for constraint check.
…nformation This change splits up the serverComponentFirmwareSetUpdate() method and implements some checks to ensure the firmware set attribute data does not get overwritten to be empty as part of an update, unless its expected. Adds additional tests to cover for firmware set attributes updates.
Codecov Report
@@ Coverage Diff @@
## main #228 +/- ##
==========================================
+ Coverage 71.69% 71.87% +0.18%
==========================================
Files 36 36
Lines 3466 3549 +83
==========================================
+ Hits 2485 2551 +66
- Misses 734 745 +11
- Partials 247 253 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
diogomatsubara
previously approved these changes
Aug 16, 2023
diogomatsubara
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RESTRICTin firmware set mapping.DeleteAll()errors.