Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vc/updates #253

Closed
wants to merge 7 commits into from
Closed

Vc/updates #253

wants to merge 7 commits into from

Conversation

DoctorVin
Copy link
Contributor

Lots of stuff here to try and get the repo in more robust shape.

  1. Changed to the Equinix Metal fork of sqlboiler-crdb. Not that while it's better than the unmaintained fork, it's still broken and I modified some generated code in situ to try and get this going. I'll submit a PR upstream so we can get a not-broken generator in place.
  2. The upgrade of sqlboiler pushed some API changes on us. I think I got all that needs doing for that, but we'll know more when. the integration tests are in a better spot.
  3. I did some housekeeping changes.

@Alva8756 @joelrebel

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9089164) 72.72% compared to head (09d67b0) 72.74%.

Files Patch % Lines
internal/dbtools/testtools.go 66.66% 0 Missing and 1 partial ⚠️
pkg/api/v1/router_server.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
+ Coverage   72.72%   72.74%   +0.01%     
==========================================
  Files          38       38              
  Lines        3733     3735       +2     
==========================================
+ Hits         2715     2717       +2     
  Misses        760      760              
  Partials      258      258              
Flag Coverage Δ
unittests 72.74% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DoctorVin DoctorVin closed this Dec 18, 2023
@DoctorVin DoctorVin deleted the vc/updates branch December 19, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants