Change Dockerfile base image #255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* merge all sql files into one * insert-into BMC to server-credential-types * regenerate sqlboiler crdb --add-soft-deletes
* update gitignore for vim backup files * regenerate ORM layer with metal-toolbox sqlboiler-crdb * WARNING! I changed a generated file here. I will update once I have a fix in place upstream * fix up linting * update to sqlboiler v4 4.15 * regen models with --enable-soft-delete
|
Created PR to the wrong repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the migration job(create tables to
crdb) doesn't take effect.Job logs only provide limit information:
no migrations to run.It's good to have shell access to either
fleetdborfleetdb-migrationpod to investigate deeper. However, existing imagegcr.io/distroless/staticdoesn't support shell :( https://github.com/GoogleContainerTools/distroless/blob/main/README.mdWe can revert the image back in the future. However it would be helpful for us to switch to some image that allows us debugging inside the pod.