Use golangci-lint config from metal-toolbo/golangci-lint-config #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All the whitespace ones where from |
mmlb
force-pushed
the
use-golangci-lint-config
branch
from
0f72323 to
4c6c0f5
Compare
|
I broke out the gofumpt/gci changes to a different commit so that the actual code changes are easier to review. |
|
@mmlb if you can rebase this on main, we should be good to go |
mmlb
force-pushed
the
use-golangci-lint-config
branch
from
adee0fb to
c093e53
Compare
done |
These are going to be enabled in the next commit when we switch to the .golangci.yml from metal-toolbox/golangci-lint-config. Better to do it before since it'll make the diff in that commit more meaningful.
ofaurax
force-pushed
the
use-golangci-lint-config
branch
2 times, most recently
from
ce73a66 to
4bbb2a9
Compare
ofaurax
force-pushed
the
use-golangci-lint-config
branch
from
801e08b to
7caf216
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few things going on in this PR:
go run $package@$versioninstead of golangci-lint from the env so we all use the same verion.golangci-lint, v1.57.