bootstrap: add support for data secret

We can configure bootstrap by setting `ConfigRef` or `DataSecretName`. Here, we correct the logic that determines if bootstrapping is ready to allow the data secret method as well as `ConfigRef`. Signed-off-by: Honza Pokorny <[email protected]>
metal3-io · Nov 12, 2024 · 85179ba · 85179ba
1 parent 2073b84
commit 85179ba
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/baremetal/metal3machine_manager.go b/baremetal/metal3machine_manager.go
@@ -171,7 +171,11 @@ func (m *MachineManager) IsProvisioned() bool {
 
 // IsBootstrapReady checks if the machine is given Bootstrap data.
 func (m *MachineManager) IsBootstrapReady() bool {
-	return m.Machine.Status.BootstrapReady
+	if m.Machine.Spec.Bootstrap.ConfigRef != nil {
+		return m.Machine.Status.BootstrapReady
+	}
+
+	return m.Machine.Spec.Bootstrap.DataSecretName != nil
 }
 
 // isControlPlane returns true if the machine is a control plane.

diff --git a/baremetal/metal3machine_manager_test.go b/baremetal/metal3machine_manager_test.go
@@ -429,6 +429,8 @@ var _ = Describe("Metal3Machine manager", func() {
 		ExpectTrue bool
 	}
 
+	testCaseBootstrapReadySecretName := "secret"
+
 	DescribeTable("Test BootstrapReady",
 		func(tc testCaseBootstrapReady) {
 			machineMgr, err := NewMachineManager(nil, nil, nil, &tc.Machine, nil,
@@ -442,6 +444,11 @@ var _ = Describe("Metal3Machine manager", func() {
 		},
 		Entry("ready", testCaseBootstrapReady{
 			Machine: clusterv1.Machine{
+				Spec: clusterv1.MachineSpec{
+					Bootstrap: clusterv1.Bootstrap{
+						ConfigRef: &corev1.ObjectReference{},
+					},
+				},
 				Status: clusterv1.MachineStatus{
 					BootstrapReady: true,
 				},
@@ -452,6 +459,16 @@ var _ = Describe("Metal3Machine manager", func() {
 			Machine:    clusterv1.Machine{},
 			ExpectTrue: false,
 		}),
+		Entry("ready data secret", testCaseBootstrapReady{
+			Machine: clusterv1.Machine{
+				Spec: clusterv1.MachineSpec{
+					Bootstrap: clusterv1.Bootstrap{
+						DataSecretName: &testCaseBootstrapReadySecretName,
+					},
+				},
+			},
+			ExpectTrue: true,
+		}),
 	)
 
 	DescribeTable("Test setting errors",