-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps!(python): drop Python 3.7 support and mark some arguments as positional-only #162
Open
XuehaiPan
wants to merge
4
commits into
main
Choose a base branch
from
drop-py37
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuehaiPan
added
cxx
Something related to the CXX source code
py
Something related to the Python source code
dependencies
Pull requests that update a dependency file
labels
Oct 8, 2024
XuehaiPan
force-pushed
the
drop-py37
branch
2 times, most recently
from
October 8, 2024 17:23
31b074e
to
1a7f39f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 36
Lines 3867 3783 -84
=========================================
- Hits 3867 3783 -84
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
XuehaiPan
force-pushed
the
drop-py37
branch
2 times, most recently
from
October 9, 2024 03:17
64e623f
to
57f9847
Compare
XuehaiPan
force-pushed
the
drop-py37
branch
3 times, most recently
from
October 14, 2024 19:49
6b5974a
to
6882445
Compare
XuehaiPan
force-pushed
the
drop-py37
branch
10 times, most recently
from
October 24, 2024 09:28
b5990e3
to
ae89038
Compare
XuehaiPan
force-pushed
the
drop-py37
branch
3 times, most recently
from
October 25, 2024 10:18
91a8016
to
d028d06
Compare
XuehaiPan
force-pushed
the
drop-py37
branch
3 times, most recently
from
October 30, 2024 08:51
31cd99d
to
67a1fc3
Compare
XuehaiPan
force-pushed
the
main
branch
2 times, most recently
from
October 31, 2024 12:46
fc931bc
to
46731f5
Compare
XuehaiPan
force-pushed
the
drop-py37
branch
4 times, most recently
from
November 12, 2024 07:49
2d1a031
to
778438e
Compare
XuehaiPan
force-pushed
the
drop-py37
branch
4 times, most recently
from
November 19, 2024 17:49
4823079
to
ec013d6
Compare
XuehaiPan
force-pushed
the
drop-py37
branch
3 times, most recently
from
November 24, 2024 17:33
cd3d133
to
967331f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cxx
Something related to the CXX source code
dependencies
Pull requests that update a dependency file
py
Something related to the Python source code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail.
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213
if this solves the issue #15213Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format
. (required)make lint
. (required)make test
pass. (required)