Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lamports to API response for getAsset-based methods #118

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

RequescoS
Copy link
Contributor

No description provided.

@@ -397,4 +397,5 @@ pub struct Asset {
pub supply: Option<Supply>,
pub mutable: bool,
pub burnt: bool,
pub lamports: u64,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will every asset including a compressed one have a balance? If not, Option will make more sense here

Copy link
Contributor

@n00m4d n00m4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with commend above. Overall all good!

Copy link
Collaborator

@StanChe StanChe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! It would be even better to have some tests to showcase the resulting responses.

@StanChe StanChe merged commit ce00647 into main Feb 13, 2024
1 check passed
@StanChe StanChe deleted the feat/lamports branch February 13, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants