chore(ci): clean up env some more & downsize compose #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armyhaylenko
force-pushed
the
feature/MTG-1358-clean-up-compose
branch
from
b85c984 to
ec8db13
Compare
nft_ingester/src/config.rs
Outdated
| @@ -533,7 +533,7 @@ fn parse_json_to_json_middleware_config(s: &str) -> Result<JsonMiddlewareConfig, | |||
| parse_json(s) | |||
| } | |||
|
|
|||
| fn parse_json_to_big_table_config(s: &str) -> Result<BigTableConfig, String> { | |||
| pub fn parse_json_to_big_table_config(s: &str) -> Result<BigTableConfig, String> { | |||
There was a problem hiding this comment.
fn parse_json_to_dict(s: &str) -> Result<Dict, String> {
parse_json(s)
}
fn parse_json_to_json_middleware_config(s: &str) -> Result<JsonMiddlewareConfig, String> {
parse_json(s)
}
pub fn parse_json_to_big_table_config(s: &str) -> Result<BigTableConfig, String> {
parse_json(s)
}Is it possible to get rid of these methods?
There was a problem hiding this comment.
i don't think we can specify type args in value_parser in the macro
kstepanovdev
previously approved these changes
Feb 24, 2025
armyhaylenko
force-pushed
the
feature/MTG-1358-clean-up-compose
branch
2 times, most recently
from
a5ce7be to
0a81533
Compare
andrii-kl
previously approved these changes
Feb 25, 2025
armyhaylenko
force-pushed
the
feature/MTG-1358-clean-up-compose
branch
from
bf6a2a9 to
d6c6618
Compare
armyhaylenko
force-pushed
the
feature/MTG-1358-clean-up-compose
branch
from
d6c6618 to
69f85a2
Compare
armyhaylenko
force-pushed
the
feature/MTG-1358-clean-up-compose
branch
from
69f85a2 to
df3ca40
Compare
andrii-kl
approved these changes
Feb 25, 2025
kstepanovdev
approved these changes
Feb 25, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.