Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mtg-1380] fix(api): getAssetsByCreator doesn't return empty fields #444

Merged
merged 5 commits into from
Mar 6, 2025

Conversation

andrii-kl
Copy link
Collaborator

  • Return empty string for all collection_metadata fields if we have no values

- Return empty string for all collection_metadata fields if we have no values
@andrii-kl andrii-kl added the bug Something isn't working label Mar 5, 2025
@andrii-kl andrii-kl self-assigned this Mar 5, 2025
@andrii-kl andrii-kl changed the title MTG-1380 getAssetsByCreator doesn't return empty fields [mtg-1380] fix(api): getAssetsByCreator doesn't return empty fields Mar 5, 2025
Copy link
Contributor

@armyhaylenko armyhaylenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LBTM

@andrii-kl andrii-kl requested a review from kstepanovdev March 6, 2025 11:32
Copy link
Contributor

@kstepanovdev kstepanovdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrii-kl andrii-kl merged commit 333dbcd into develop Mar 6, 2025
10 checks passed
@andrii-kl andrii-kl deleted the fix/MTG-1380_fix_api_response_data_structure branch March 6, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants