feat(nft_ingester): improve cancellation of signature fetching #450
+81
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armyhaylenko
force-pushed
the
feature/MTG-1394-improve-shutdown-speed
branch
from
7b5c364 to
41940b7
Compare
| let mut rate_guard = rate.lock().unwrap(); | ||
| *rate_guard = current_rate; | ||
| } | ||
| *rate.lock().unwrap() = current_rate; |
There was a problem hiding this comment.
Will not it be locked until the end of the scope? Was it fixed in 2024 edition?
There was a problem hiding this comment.
i'll roll it back as a safeguard but honestly idk
StanChe
reviewed
Mar 12, 2025
armyhaylenko
force-pushed
the
feature/MTG-1394-improve-shutdown-speed
branch
from
41940b7 to
c0e9667
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.