Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding batch IX processing. #199

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding batch IX processing. #199

wants to merge 1 commit into from

Conversation

blockiosaurus
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mpl-core-js-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 6:28pm

@@ -292,4 +292,8 @@ pub(crate) enum MplAssetInstruction {
#[account(5, name="system_program", desc = "The system program")]
#[account(6, optional, name="log_wrapper", desc = "The SPL Noop Program")]
UpdateV2(UpdateV2Args),

/// Execute multiple instructions.
#[account(0, optional, name="dummy", desc = "Dummy account")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if you leave this out? I'm guessing the autogeneration just errors out because it needs at least one account.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, Shank will fail to generate. And it fails the whole enum macro so you can't even hardcode it.

Copy link
Contributor

@danenbm danenbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with one question above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants