Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build torch wheels on CI #352

Merged
merged 10 commits into from
Dec 6, 2024
Merged

Build torch wheels on CI #352

merged 10 commits into from
Dec 6, 2024

Conversation

Luthaf
Copy link
Member

@Luthaf Luthaf commented Nov 28, 2024

@Luthaf Luthaf force-pushed the build-torch-wheels branch 16 times, most recently from cb5e1fd to 882bb87 Compare December 3, 2024 14:42
@Luthaf Luthaf force-pushed the build-torch-wheels branch from 882bb87 to fbfd35b Compare December 4, 2024 14:25
@Luthaf Luthaf marked this pull request as ready for review December 4, 2024 14:26
@Luthaf Luthaf requested a review from PicoCentauri December 4, 2024 16:32
path: wheels
name: sdist

- name: Re-upload a single wheels artifact
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this? Aren't the wheels already stored?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are stored, but since actions/upload-artifact@v4, each upload is a separate file. This enables us to give a single link to download in the PR

@Luthaf Luthaf merged commit 4aa584c into metatensor:main Dec 6, 2024
56 checks passed
@Luthaf Luthaf deleted the build-torch-wheels branch December 6, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants