-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds sample selection to equivariant power spectrum #376
Conversation
@@ -4,6 +4,7 @@ | |||
import numpy as np | |||
import pytest | |||
from metatensor import Labels, TensorBlock, TensorMap | |||
from metatensor.operations import equal, join |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't import from metatensor.operations
. This could be written
from metatensor import equal, join
Or even better
from metatensor.operations import equal, join | |
import metatensor as mts |
and down the line mts.equal
, mts.join
(like you would not do from numpy import log
but instead use np.log
where required)
Thanks, looks very good overall! I just have one style comment about importing metatensor operations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bananenpampe !
python/featomic/tests/clebsch_gordan/equivariant_power_spectrum.py
Outdated
Show resolved
Hide resolved
…m.py Co-authored-by: Joseph W. Abbott <[email protected]>
test makes the naming consitent with the other tests |
Adds sample selection to the equivariant power spectrum convenience class.