Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pet documentation clarificaton #268

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

spozdn
Copy link
Collaborator

@spozdn spozdn commented Jun 20, 2024

Adding an additional clarification to PET documentation.


📚 Documentation preview 📚: https://metatrain--268.org.readthedocs.build/en/268/

@spozdn spozdn requested a review from DavideTisi June 20, 2024 15:39
@frostedoyster
Copy link
Collaborator

frostedoyster commented Jun 20, 2024

I think the basic issue here is not one of documentation, it's more that the default parameters shouldn't be parameters that get you (close to) state of the art accuracy, but they should be parameters that provide a good potential with decent speed (both training and inference) in practice. Then we can have a section of the docs to explain how to change parameters to get better accuracy (pretty much as in the other architectures we have)

Let's try to come up with a better set of defaults in this PR

@spozdn
Copy link
Collaborator Author

spozdn commented Jun 27, 2024

Given the discussion with @frostedoyster, we agreed to separate the issues of incomplete documentation and a demand for a more lightweight and fast model. The latter is discussed here - #273, and, thus, is uncoupled from this pr.

@frostedoyster frostedoyster merged commit 0ca1874 into main Jun 27, 2024
14 checks passed
@frostedoyster frostedoyster deleted the pet_documentation_update branch June 27, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants