Fix a small bug in NativePET preventing training with arbitrary targets
#546
+38
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/metatrain/experimental/nativepet/model.py:538
- Direct assignment for edge predictions with the same key risks overwriting data when multiple predictions exist. Accumulating these predictions in a list might be more appropriate.
edge_atomic_predictions_dict[output_name] = (
abmazitov
approved these changes
Apr 9, 2025
frostedoyster
force-pushed
the
fix-nativepet-arbitrary-targets
branch
from
db29379 to
5f9d18c
Compare
frostedoyster
force-pushed
the
fix-nativepet-arbitrary-targets
branch
from
5f9d18c to
7901b6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://metatrain--546.org.readthedocs.build/en/546/