Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed restriction on output props type so it does not have to take … #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

srmelody
Copy link

…all container props

In the current type definition, you have to pass all input props that the container is taking to the component that the container is managing the interaction with the meteor collections. In this change, I'm allowing the container to selectively pass props. This allows existing component libraries (Material-UI, react-bootstrap) to plug in without needing to wrap the components.

I'm using this change locally in my typings directory.

@srmelody
Copy link
Author

@fullflavedave can you take a look at this pull request?

@fullflavedave
Copy link
Collaborator

fullflavedave commented Jun 30, 2017 via email

@fullflavedave
Copy link
Collaborator

fullflavedave commented Jun 30, 2017

Is the extra closing parenthesis on the changed line a typo?
export function createContainer<InP, D, OutP)>(

I have to admit that I haven't use TypeScript with Meteor for a while, and I don't have the time today to make sure it won't break existing usage (e.g. a managed component relies on the implicit forwarding of the container inputs). I'll take your word for it, though, unless anyone else chimes in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants