Object Reference Types #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a trait for object references and refactored the StdReference as a newtype (ObjectReference2) and behind the trait so we can support it side by side with the older object references.
This commit represents an MVP for object references. This includes the implementation of Object1 for 1.8 and later, and Object2 for 1.12 and later.
The wrapper to H5RCopy is causing issues in some enviroments. This commit removes it for now as it isn't critical to the basic object implementation.
There appear to be bugs in the v1.12.0 version which certainly break ObjectReference2 is an element in compound type. Other bugs were seen previously as well so this appears to be a more stable option.
JamesMc86
force-pushed
the
feature/refs2
branch
from
a435a1d
to
348defc
Compare
Needed to add the check cfg for the version features in the hdf-types library
magnusuMET
reviewed
Nov 22, 2024
JamesMc86
added a commit
to WiresmithTech/hdf5-rust
that referenced
this pull request
Nov 26, 2024
This change adds the private ObjectReferencePrivate trait which is used to seal the ObjectReference trait and prevent outside implementations. Refs: metno#36
This change adds the private ObjectReferencePrivate trait which is used to seal the ObjectReference trait and prevent outside implementations. Refs: metno#36
JamesMc86
force-pushed
the
feature/refs2
branch
from
6154664
to
c461ec1
Compare
|
Thanks @JamesMc86! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi All,
This is the work I had done for the other branch to add a minimal first version of object references. (see aldanor#279).
It adds ObjectReference1 as pre-1.12 object references and ObjectReference2 as the new reference types based on the STD_REF type.
I've tried to make this useful without being too large and can build on it further.
I've rebased that work onto your new main for this PR.
Let me know if there are any questions or anything else needed