Better implementation of maps_freq: convert ts_types to TsType in EvalSetup and modify usage in code #1267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
The goal here is to have all
ts_type
-like objects defined in a config be converted to actualTsType
instances so that they do not need to be converted all over the place later in the code. This PR therefore defines the interface of having allTsType
attributes defined upon config initialization. Will need to makeTsType
JSON serializable, and think about its structure. Longer-term project at it breaks a lot of tests and current functionality. Probably something to talk about at a design workshop. I think this approach is preferable but maybe there are other ideas worth considering.Related issue number
Related to #1259
Checklist