Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variables_changed_units_categories #1418

Open
wants to merge 4 commits into
base: main-dev
Choose a base branch
from

Conversation

andrearosendahl
Copy link
Collaborator

Change Summary

Added two more categories for the variables, surface emission and column burden. Also changed the units for some deposition, emission and load variables.

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@andrearosendahl andrearosendahl marked this pull request as draft November 22, 2024 07:52
@andrearosendahl andrearosendahl marked this pull request as ready for review November 22, 2024 07:53
@jgriesfeller jgriesfeller added the good first issue Good for newcomers label Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.57%. Comparing base (e5f5c8a) to head (8aba5e0).
Report is 1 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1418   +/-   ##
=========================================
  Coverage     78.57%   78.57%           
=========================================
  Files           137      137           
  Lines         20892    20894    +2     
=========================================
+ Hits          16415    16417    +2     
  Misses         4477     4477           
Flag Coverage Δ
unittests 78.57% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lewisblake lewisblake added this to the m2025-01 milestone Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants