Updated the local trajectory module #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added FORD style documentation - Removed unused function uEMEP_local_trajectory - Updated function names to be more descriptive - Minor code enhancements for improved readability - Reals no longer test on equality
brucerd
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the local trajectory module
@brucerd I need you to look through the descriptions of the input and output variables, as I am not 100% sure it is correct.
Testing
I have not written unit tests for this module even if it is highly relevant. The functions depends on several variables/parameters set in
uemep_definitions. It was very difficult to set this up to allow the tests to run properly. We should consider having a default config file for testing. The code changes pass regression testing.