Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename old reitit.ring.spec and move multipart specs to new ns #371

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Deraen
Copy link
Member

@Deraen Deraen commented Mar 5, 2020

This should fix #355 #356

@Deraen Deraen requested a review from ikitommi March 5, 2020 12:48
@ikitommi
Copy link
Member

This is a major breaking change. I propose we'll postpone this to 1.0.0, could be soon (lot's of other... wrong things like the one this fixes.

@ikitommi ikitommi added this to the 1.0.0 milestone May 12, 2020
@miikka
Copy link
Contributor

miikka commented May 22, 2020

This could be handled in staged fashion to

  1. Move the specs to new a namespace from multipart.clj but add aliases for them in multipart.clj. Document that the aliases are deprecated (update code examples, add comment in code, entry in changelog. Nobody is looking at ^:deprecated tags for specs, I guess.)
  2. Later remove the aliases when doing a breaking release.

I'm not sure why reitit.ring.spec is renamed reitit.ring.validate.spec ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reitit.ring.middleware.multipart requires spec-tools.core
3 participants