Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quoting paths when sending them to open command #220

Merged
merged 2 commits into from
Apr 27, 2014
Merged

Quoting paths when sending them to open command #220

merged 2 commits into from
Apr 27, 2014

Conversation

nickveys
Copy link

Paths with spaces or other naughty things were causing the open to fail.

@bf4
Copy link
Member

bf4 commented Apr 27, 2014

Would you like to add a line for this in the HISTORY.md? Just add a commit to your quote-open-path branch and push the new commit to it. It'll add it to this PR. Otherwise, I'll just merge and write it for you.

@nickveys
Copy link
Author

Done. Thanks!

@bf4
Copy link
Member

bf4 commented Apr 27, 2014

Great! Wanna add Launchy support?

bf4 added a commit that referenced this pull request Apr 27, 2014
[Fix] Quoting paths when sending them to open command
@bf4 bf4 merged commit cd78339 into metricfu:master Apr 27, 2014
@nickveys
Copy link
Author

Yeah I can take a look. I see #113 referencing that, are you just doing that in the master branch towards 5.0?

@bf4
Copy link
Member

bf4 commented Apr 29, 2014

Pretty much. I haven't figured out how to use github for project management. I don't want to create a million issues, but then I forget to synch ideas with implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants