Fixes build sequence to include Angular build #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d "build" to combine it with React
lmangani
approved these changes
Mar 20, 2024
package.json
Outdated
| @@ -3,7 +3,7 @@ | |||
| "version": "10.0.11", | |||
| "description": "Test plugin to lern dev enveroument", | |||
| "scripts": { | |||
| "build": "webpack -c ./.config/webpack/webpack.config.ts --env production", | |||
| "build": "cd ./ngx-flow && npm run build:component && cd .. && webpack -c ./.config/webpack/webpack.config.ts --env production", | |||
There was a problem hiding this comment.
I would propose splitting this in two scripts we can call in sequence ie: build-ngx and build rather than mixing them together and then in the action npm run build-npx && npm run build
|
Separated build into two stages, one for Angular plugin and one for whole package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package.jsonci.yml. Successful action run: https://github.com/AlexeyOplachko/grafana-flow/actions/runs/8361033313/job/22888112495release.yml. Successful action run: https://github.com/AlexeyOplachko/grafana-flow/actions/runs/8361038672/job/22888131143Successful release: https://github.com/AlexeyOplachko/grafana-flow/releases/tag/v10.0.11
Validated that it includes changes that were missing due to angular build issues