clean: fix handling of files from *_copied.json #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the --copiedRuns argument is used, clean grabs the files to remove from the *_copied.json file set up when a run uses --copy_lvl. *_copied.json records the files as absolute paths. clean doesn't process absolute paths correctly because it unconditionally prepends a directory, leading to an invalid path. As a result, the files don't get removed. Update clean to only append dir if the file isn't an absolute path.
clean ignores errors because it doesn't want to halt the process. However, silently dropping the error makes it hard to catch issues like the one fixed by the previous commit.
The repeated entries in extrapolateCopyFilesFromExtensions lead to the *_copied.json files listing the file twice. As a result, 'clean --copiedRuns ...` tries to remove the file twice, leading to a failure (converted to a logged message as of the last commit, and silently dropped before that).
seth127
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue I noticed when working on the
cleanexamples for gh-329.