Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update goreleaser configuration #332

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Update goreleaser configuration #332

merged 5 commits into from
Aug 28, 2024

Conversation

kyleam
Copy link
Collaborator

@kyleam kyleam commented Aug 28, 2024

The goreleaser action (added in gh-323) requires version 2 of the config format.

kyleam added 5 commits August 27, 2024 20:02
The goreleaser action set up in 1449d16 (ci: switch to GitHub
Actions, 2024-08-09) requires version 2 of the format.

Note that there is already a "builds" section that is compatible with
version 2.  Presumably the "build" section being removed by this
commit had no effect in the version of goreleaser used in the older
Drone build.

According to 'goreleaser check', this is config is now valid.
The builtin GITHUB_TOKEN is sufficient for goreleaser to make a
release in _this_ repository, but a custom token is needed in order to
push to a different repository than the one workflow is running in
(metrumresearchgroup/homebrew-tap in this case).

Set GH_GORELEASER_BREWS_TOKEN in the environment.  (The previous
commit updated the brew's section of the goreleaser config to use
this.)
cmd/bbi/goreleaser.yml expects this to be defined.
Our current practice is to manually add the release's entries from
NEWS.md to the release.
These days we update the top of the release with the NEWS entries for
the release, so it makes sense to have goreleaser publish it as a
draft.
@kyleam
Copy link
Collaborator Author

kyleam commented Aug 28, 2024

goreleaser action successfully created a release.

https://github.com/metrumresearchgroup/bbi/actions/runs/10587782044/job/29339178047

https://github.com/metrumresearchgroup/bbi/releases/tag/v3.3.1-rc.1

metrumresearchgroup/homebrew-tap@58b67cf

Confirmed builds for macOS and Linux looks as expected (bbi version and bbi nonmem summary --help)

Copy link
Collaborator

@seth127 seth127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@kyleam kyleam merged commit ecafa93 into main Aug 28, 2024
7 checks passed
@kyleam kyleam deleted the goreleaser-update branch August 28, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants