Release 1.12.0 #718
Merged
Release 1.12.0 #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Towards the end of PR #711 I changed which model was passed to `nm_data(filter = TRUE)`. While updating the NEWS I realized some parameter documentation and an error message were not consistent with this change. - Minor enough to include in this PR
Scorecard Details
|
kyleam
approved these changes
Sep 20, 2024
NEWS.md
Outdated
Comment on lines
34
to
35
| aforementioned bug and removes the need for the based on model (the model being | ||
| bootstrapped) from needing to have been executed. If the model has been executed |
There was a problem hiding this comment.
Maybe simplify to something like "removes the requirement that the base model (the model being bootstrapped) has been executed"? (Main thing there is to get rid of the "need ... from needing".)
There was a problem hiding this comment.
ooh gross I cant believe I wrote it that way. Good catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changeset: 1.11.0...release/1.12.0