Dev #13
Merged
Dev #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o change orientation ODE to take and return 2nd-order orientation tensor in tensorial form (3x3) instead of flat representation (9x1). Also move computation of sym. and skew sym. part of the velocity gradient to wrapper function.
…ed imports in `/orientation.py`.
…pynb` since the calling signature of `orthotropic_fitted_closures` and `integrate_ori_ode` don't match. Added `nbstripout` to `pre-commit-config.yaml` to remove output from Jupyter Notebooks.
Dev update reorientation
LouisSchreyer
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some additional changes to the pull request from @LouisSchreyer:
integrate_ori_odewrapper.orthofitclosures_perfectshear.ipynb" to work with theintegrate_ori_ode` wrapper. I used lambda functions to work with the orthotropic_fitted_closures instead of splitting them into different wrappers. However, wrappers would be also a good solution.It's not all super clean, but updated to 2024 and consistent at least.