feat: Add support for block replacement #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the player right-clicks with a block in hand, the position where this block should be placed is subject to a condition: If the block currently at the click position is considered "replaceable", the new block should be placed right there. Otherwise, it should be placed next to the clicked position (depending on which side of the block was clicked). Before this patch, the code didn't take this into account - always placing the new block adjacent to the clicked position. Now, this is handled for the following replaceable block types: - air (all three kinds) - liquids (water, lava) - tall grass There may be further kinds of replaceable blocks in the game; these can be added in the future via an extendable callback mechanism.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the player right-clicks with a block in hand, the position where this block should be placed is subject to a condition: If the block currently at the click position is considered "replaceable", the new block should be placed right there. Otherwise, it should be placed next to the clicked position (depending on which side of the block was clicked).
Before this patch, the code didn't take this into account - always placing the new block adjacent to the clicked position. Now, this is handled for the following replaceable block types:
There may be further kinds of replaceable blocks in the game; these can be added in the future via an extendable callback mechanism.