Switch development config to use ConfigAggregator #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kynx
force-pushed
the
development-config-aggregator
branch
from
fc84369
to
12a0827
Compare
Xerkus
requested changes
Jan 8, 2024
There was a problem hiding this comment.
I think this file should be renamed local.dev.php.dist
kynx
force-pushed
the
development-config-aggregator
branch
from
4d447d1
to
cb85ca5
Compare
|
You might want to rebase |
added 3 commits
February 15, 2024 11:02
Signed-off-by: matt <[email protected]>
Signed-off-by: matt <[email protected]>
Signed-off-by: matt <[email protected]>
kynx
force-pushed
the
development-config-aggregator
branch
from
cb85ca5
to
e404ba9
Compare
|
Grrr.... done. |
|
Hey @Xerkus I ended up using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes
development.config.php.distto use aConfigAggregatorso laminas/laminas-component-installer#68 can inject--dev-only config providers. It also adds the ability to load dev-only configuration from{,*.}{global,local}-development.phpfiles - like MVC does - so settings in the development config providers can be overridden.I'm not sure what I can do to test these changes. As far as I can tell the existing tests don't cover the structure of the config files, but if anyone's got any pointers...