Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand compatibility to allow psr/http-message:^2 #121

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

Xerkus
Copy link
Member

@Xerkus Xerkus commented Aug 23, 2023

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

#114 provided compatibility with psr http message v2 but missed SwooleStream which was not caught by tests since v2 was never pulled by composer in CI.

@Xerkus Xerkus added the Bug Something isn't working label Aug 23, 2023
@Xerkus Xerkus added this to the 2.7.1 milestone Aug 23, 2023
@Xerkus Xerkus linked an issue Aug 23, 2023 that may be closed by this pull request
@Xerkus Xerkus modified the milestones: 2.7.1, 4.7.1 Aug 23, 2023
src/SwooleStream.php Show resolved Hide resolved
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Xerkus

@Ocramius Ocramius self-assigned this Aug 23, 2023
@Ocramius Ocramius added Enhancement New feature or request dependencies Pull requests that update a dependency file labels Aug 23, 2023
@Ocramius Ocramius modified the milestones: 4.7.1, 4.8.0 Aug 23, 2023
@Ocramius Ocramius changed the base branch from 4.7.x to 4.8.x August 23, 2023 23:44
@Ocramius Ocramius changed the title Fix compatibility with psr http message v2 Expand compatibility to allow psr/http-message:^2 Aug 23, 2023
@Ocramius Ocramius removed the Bug Something isn't working label Aug 23, 2023
@Ocramius Ocramius merged commit bee6718 into mezzio:4.8.x Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.7.0 is not compatible with psr/http-messages:^2.0
2 participants