Skip to content

Commit

Permalink
Relay modal text update (distributed-system-analysis#3534)
Browse files Browse the repository at this point in the history
Provide a better description of the Relay modal dialog
  • Loading branch information
MVarshini authored Aug 30, 2023
1 parent 30505a2 commit 1a7394b
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -419,10 +419,12 @@ export const MetadataRow = (props) => {
return (
<Table className="box" key={uid()} aria-label="metadata-table">
<Thead>
<Th width={25} textCenter>
{columnNames.key}
</Th>
<Th width={40}>{columnNames.value}</Th>
<Tr>
<Th width={25} textCenter>
{columnNames.key}
</Th>
<Th width={40}>{columnNames.value}</Th>
</Tr>
</Thead>
<Tbody>
{checkedItems.map((attr) => {
Expand Down
18 changes: 15 additions & 3 deletions dashboard/src/modules/components/RelayUIComponent/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@ const AboutComponent = () => (
);
const PopoverComponent = () => (
<Popover
aria-label="Basic popover"
aria-label="Relay About Popover"
headerContent={<div>About</div>}
bodyContent={<AboutComponent />}
maxWidth="4vw"
>
<Button variant="plain" aria-label="About">
<Button variant="plain" aria-label="About" className="popover-btn">
<OutlinedQuestionCircleIcon />
</Button>
</Popover>
Expand All @@ -73,9 +73,21 @@ const RelayComponent = () => {
onClose={handleClose}
>
<div className="modal-heading">
<Title headingLevel="h3">Relay</Title>
<Title headingLevel="h3">Pull Datasets</Title>
<PopoverComponent />
</div>
<p className="modal-desc">
When you use the Pbench Agent{" "}
<span className="italicized"> pbench-results-move </span> command with
the
<span className="italicized"> --relay </span>option to push results to a
relay server, the command will report a URL.
</p>
<p className="modal-desc">
Enter that URL here to instruct the Pbench Server to upload the results
data from the relay and remove it from the relay.
</p>

<div className="card-wrapper">
<Card>
<CardBody>
Expand Down
11 changes: 10 additions & 1 deletion dashboard/src/modules/components/RelayUIComponent/index.less
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,18 @@
}
.modal-heading {
display: flex;
.popover-btn {
padding-top: 0;
padding-bottom: 0;
}
}
.modal-desc {
margin: 1vh 0;
.italicized {
font-style: italic;
}
}
.card-wrapper {
height: 45vh;
display: flex;
align-items: center;
justify-content: center;
Expand Down

0 comments on commit 1a7394b

Please sign in to comment.