PBENCH-1253 (distributed-system-analysis#3532)

Edit Server deletion date not working
mfleader · Aug 25, 2023 · cc58130 · cc58130
1 parent ba208a4
commit cc58130
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 4 deletions.
diff --git a/dashboard/src/modules/components/OverviewComponent/NewRunsComponent.jsx b/dashboard/src/modules/components/OverviewComponent/NewRunsComponent.jsx
@@ -5,6 +5,7 @@ import {
   IS_ITEM_SEEN,
   NAME_KEY,
   ROWS_PER_PAGE,
+  SERVER_DELETION_KEY,
   START_PAGE_NUMBER,
   USER_FAVORITE,
 } from "assets/constants/overviewConstants";
@@ -29,6 +30,7 @@ import React, { useCallback, useState } from "react";
 import {
   deleteDataset,
   editMetadata,
+  getEditedMetadata,
   getMetaDataActions,
   setRows,
   setRowtoEdit,
@@ -97,8 +99,7 @@ const NewRunsComponent = () => {
     dispatch(getMetaDataActions(dataset, "favorite", isFavoriting));
   };
   const saveRowData = (dataset) => {
-    const item = newRuns.find((run) => run.resource_id === dataset.resource_id);
-    dispatch(getMetaDataActions(dataset, "datasetName", item.name));
+    dispatch(getEditedMetadata(dataset, "newRuns"));
   };
   const moreActionItems = (dataset) => [
     {
@@ -200,6 +201,13 @@ const NewRunsComponent = () => {
                         saveRowData={saveRowData}
                         rowActions={rowActions}
                         item={item}
+                        onDateSelect={(_event, str) =>
+                          updateTblValue(
+                            str,
+                            SERVER_DELETION_KEY,
+                            item.resource_id
+                          )
+                        }
                         textInputEdit={(val) =>
                           updateTblValue(val, NAME_KEY, item.resource_id)
                         }

diff --git a/dashboard/src/modules/components/OverviewComponent/SavedRunsComponent.jsx b/dashboard/src/modules/components/OverviewComponent/SavedRunsComponent.jsx
@@ -145,7 +145,7 @@ const SavedRunsComponent = () => {
                         updateTblValue(val, NAME_KEY, item.resource_id)
                       }
                       toggleEdit={toggleEdit}
-                      onDateSelect={(str) =>
+                      onDateSelect={(_event, str) =>
                         updateTblValue(
                           str,
                           SERVER_DELETION_KEY,

diff --git a/dashboard/src/modules/components/OverviewComponent/common-component.jsx b/dashboard/src/modules/components/OverviewComponent/common-component.jsx
@@ -295,7 +295,14 @@ export const NewRunsRow = (props) => {
         )}
       </Td>
       <Td dataLabel={columnNames.endtime}>
-        {formatDateTime(item.metadata[SERVER_DELETION])}
+        {item[CONSTANTS.IS_EDIT] ? (
+          <SelectDateComponent
+            value={item.metadata[SERVER_DELETION]}
+            onDateSelect={props.onDateSelect}
+          />
+        ) : (
+          formatDateTime(item.metadata[SERVER_DELETION])
+        )}
       </Td>
       <Td
         favorites={{