Provide flexibility to use different quickfix UIs in Build and Compile Actions. #730
+54
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsoufian
force-pushed
the
ns/custom_quickfix
branch
from
a60e2bc to
8298cce
Compare
|
@mfussenegger I wanted to ask if this pull request has a chance to be merged. I understand that this change might not bring a significant enhancement to most users, so please feel free to close it if it doesn't align with the project's goals or priorities. |
mfussenegger
reviewed
Jan 6, 2025
lua/jdtls.lua
Outdated
| [3] = "CANCELLED", | ||
| } | ||
| print(string.format('Compile error. (%s)', reverse_status[result])) | ||
| vim.cmd(quickfix_open_cmd) |
There was a problem hiding this comment.
I'd change this to a function like on_compile_result(items), which defaults to function(_) vim.cmd("copen") end.
It gives a bit more flexibility without making it much more complex and would also handle #733
There was a problem hiding this comment.
Thank you for the suggestion, it makes perfect sense to me. I’ve applied the change.
nsoufian
force-pushed
the
ns/custom_quickfix
branch
from
8298cce to
1a097c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new optional option
quickfix_open_cmdfor thecompileandbuild. This allows users to specify a custom command for opening the quickfix list. If not provided, the default behavior (copen) remains unchanged, ensuring backward compatibility.The added option enables seamless integration with plugins that offer enhanced quickfix UIs, such as Trouble.nvim, providing a more customizable user experience for error navigation.
Please let me know if this change aligns with the project's vision and if it can be integrated.
Thank you for creating and maintaining this amazing plugin; it has significantly enhanced my workflow!