remove Tail-Free sampling

mgonzs13 · Oct 29, 2024 · 9ffc45b · 9ffc45b
1 parent 4facfa5
commit 9ffc45b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/llama_cpp_vendor/CMakeLists.txt b/llama_cpp_vendor/CMakeLists.txt
@@ -11,7 +11,7 @@ find_package(ament_cmake REQUIRED)
 FetchContent_Declare(
   llama
   GIT_REPOSITORY https://github.com/ggerganov/llama.cpp.git
-  GIT_TAG        b3982
+  GIT_TAG        b3983
 )
 
 option(LLAMA_BUILD_COMMON "llama: build common utils library" ON)

diff --git a/llama_msgs/msg/SamplingConfig.msg b/llama_msgs/msg/SamplingConfig.msg
@@ -14,7 +14,6 @@ float32 top_p                       0.95                            # top-p samp
 float32 min_p                       0.05                            # min-p sampling (0.0 = disabled)
 float32 xtc_probability             0.00                            # xtc sampling (0.0 = disable)
 float32 xtc_threshold               0.10                            # xtc sampling threshold (> 0.5 disables XTC)
-float32 tfs_z                       1.00                            # tail free sampling, parameter z (1.0 = disabled)
 float32 typical_p                   1.00                            # locally typical sampling, parameter p (1.0 = disabled)
 
 int32 penalty_last_n                64                              # last n tokens consider for penalize (0 = disable penalty, -1 = context size)
@@ -34,7 +33,7 @@ float32 mirostat_tau                5.0                             # Mirostat t
 
 bool penalize_nl                    false                           # consider newlines as a repeatable token
 
-string samplers_sequence            "dkfypmxt"                       # TOP_K, TFS_Z, TYPICAL_P, TOP_P, MIN_P, XTC, TEMP
+string samplers_sequence            "dkypmxt"                       # DRY, TOP_K, TFS_Z, TYPICAL_P, TOP_P, MIN_P, XTC, TEMP
 
 string grammar                      ""                              # optional BNF-like grammar to constrain sampling
 string grammar_schema               ""                              # grammar schema that defines a JSON BNF grammar

diff --git a/llama_ros/llama_ros/langchain/llama_ros_common.py b/llama_ros/llama_ros/langchain/llama_ros_common.py
@@ -78,7 +78,7 @@ class LlamaROSCommon(BaseLanguageModel, ABC):
 
     penalize_nl: bool = False
 
-    samplers_sequence: str = "dkfypmxt"
+    samplers_sequence: str = "dkypmxt"
 
     grammar: str = ""
     grammar_schema: str = ""