A small change that makes it possible to pass ObjectReader as SqlDbType.Structured parameter to a stored procedure call #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe.Structured parameter to a stored procedure call
|
In this place |
mgravell
reviewed
Mar 18, 2022
| /// <param name="members">The members that should be exposed to the reader</param> | ||
| public ObjectReader(Type type, IEnumerable source, params string[] members) |
There was a problem hiding this comment.
This is a hard break; we can't do that; whatever API changes must be binary compatible; I'm less concerned about build compatible, but that would be nice too.
Adding IsKey itself: fine
There was a problem hiding this comment.
UPD Key property can be selected via expression
There was a problem hiding this comment.
I create another constructor for backwards compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change that makes it possible to pass ObjectReader as SqlDbType.Structured parameter to a stored procedure call.
This previously threw an NRF exception in the Microsoft.Data.SqlClient.GetActualFieldsAndProperties method when it tried to access a property on a non-existent column "IsKey".