more debugging stuff

mgroves · Nov 15, 2023 · 6122580 · 6122580
1 parent aaacaff
commit 6122580
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 6 deletions.
diff --git a/.github/workflows/ci-container.yml b/.github/workflows/ci-container.yml
@@ -23,7 +23,7 @@ jobs:
       Couchbase__ScanConsistency: ${{ secrets.COUCHBASE__SCANCONSISTENCY }}
       JwtSecret__Issuer: ${{ secrets.JWTSECRET__ISSUER }}
       JwtSecret__Audience: ${{ secrets.JWTSECRET__AUDIENCE }}
-      JwtSecret__SecurityKey: "thisishardcodedtryingtofigureouttheissue29mjL7uvnxE6BDqP5aT3bYRg"
+      JwtSecret__SecurityKey: ${{ secrets.JWTSECRET__SECURITYKEY }}
 
     services:
       couchbase:

diff --git a/Conduit/Conduit.Tests/Functional/FunctionalTestBase.cs b/Conduit/Conduit.Tests/Functional/FunctionalTestBase.cs
@@ -1,8 +1,6 @@
 using Conduit.Web;
 using Conduit.Web.Users.Services;
-using Microsoft.AspNetCore.Hosting;
 using Microsoft.AspNetCore.Mvc.Testing;
-using Microsoft.Extensions.DependencyInjection;
 
 namespace Conduit.Tests.Functional;
 

diff --git a/Conduit/Conduit.Tests/Unit/Users/Handlers/GetProfileHandlerTests.cs b/Conduit/Conduit.Tests/Unit/Users/Handlers/GetProfileHandlerTests.cs
@@ -28,7 +28,7 @@ public void SetUp()
         {
             Audience = "doesntmatter-audience",
             Issuer = "doesntmatter-issuer",
-            SecurityKey = "doesntmatter-securityKey"
+            SecurityKey = "doesntmatter-securityKey-doesntmatter-securityKey-doesntmatter-securityKey-doesntmatter-securityKey"
         };
         _handler = new GetProfileHandler(_userDataServiceMock.Object,
             new GetProfileRequestValidator(), 

diff --git a/Conduit/Conduit.Web/Users/Services/JwtSecrets.cs b/Conduit/Conduit.Web/Users/Services/JwtSecrets.cs
@@ -1,8 +1,24 @@
-namespace Conduit.Web.Users.Services;
+using System.Text;
+
+namespace Conduit.Web.Users.Services;
 
 public class JwtSecrets
 {
     public string Issuer { get; set; }
     public string Audience { get; set; }
-    public string SecurityKey { get; set; }
+
+    private string _securityKey;
+
+    public string SecurityKey
+    {
+        get => _securityKey;
+        set
+        {
+            byte[] byteArray = Encoding.UTF8.GetBytes(value);
+            var numBits = byteArray.Length * 8;
+            if (numBits <= 256)
+                throw new ArgumentException($"SecurityKey must be greater than 256 bits. The security key '{value}' is only '{numBits}' bits.");
+            _securityKey = value;
+        }
+    }
 }