Ib portfolio #196
Open
Ib portfolio #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ather than guessing how to create IB Contracts based on symbols+user's config
…rather than trying Python mocking.
…we'd exit backtest iteration one event too early
… -- need a full integration test to run locally
…bootstrap the portfolio's positions. Has a dependancy on using the IBPriceHandler, but I don't know how we can avoid that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was forked from #186 which basically requires fixing Travis before being ready to merge.
The IBPortfolio should act like normal Portfolio, except for initialization:
Upon connection to IB, the positions held in the account should be streamed to QSTrader, and the IBPortfolio creates the necessary positions. A call to the PriceHandler is also made, which will subscribe to the current positions so we can update portfolio value correctly.
Note that handling of position changes (buying & selling) should not be handled directly by the IBPortfolio - that should be the responsibility of the IBExecutionHandler. The ExecutionHandler should subscribe to all OrderStatus() events from IB (i.e. fills, cancels), and convert them to the relevant QSTrader event, which are then given to the Portfolio to adjust positions.
I've also started some code to keep track of accounting information, which is stored as a big ugly multi-level map that comes from IB.
There also isn't much testing done in here yet.